Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moonbeam price feeds and get networks from config #148

Merged
merged 19 commits into from
Mar 18, 2022

Conversation

gabaldon
Copy link
Collaborator

@gabaldon gabaldon commented Mar 10, 2022

close #150

packages/api/src/types.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/ui/components/Main.vue Outdated Show resolved Hide resolved
@gabaldon gabaldon force-pushed the add-moonbean-price-feeds branch 2 times, most recently from bef3583 to 78cea10 Compare March 11, 2022 12:41
@gabaldon gabaldon force-pushed the add-moonbean-price-feeds branch 2 times, most recently from 8297b81 to 4b4a8af Compare March 15, 2022 14:15
@aesedepece aesedepece changed the title Add moonbean price feeds and get networks from config Add moonbeam price feeds and get networks from config Mar 15, 2022
packages/api/src/utils/index.ts Show resolved Hide resolved
packages/api/src/web3Middleware/provider.ts Outdated Show resolved Hide resolved
packages/ui/components/DataFeedDetails.vue Outdated Show resolved Hide resolved
packages/api/src/resolvers.ts Outdated Show resolved Hide resolved
packages/api/src/index.ts Show resolved Hide resolved
packages/api/src/index.ts Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
@gabaldon gabaldon force-pushed the add-moonbean-price-feeds branch 2 times, most recently from e5def90 to 9fb70ad Compare March 16, 2022 11:12
packages/ui/components/NavBar.vue Outdated Show resolved Hide resolved
packages/ui/utils/generateNavOptions.js Outdated Show resolved Hide resolved
packages/api/test/getNetworksConfig.spec.ts Outdated Show resolved Hide resolved
label: 'Conflux Testnet',
chain: 'Conflux'
},
{ key: 'conflux-tethys', label: 'Conflux Tethys', chain: 'Conflux' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw after the Hydra hard fork, this is now apparently called Conflux Core

label: 'Polygon Mainnet',
chain: 'Polygon'
},
{ key: 'polygon-goerli', label: 'Polygon Goerli', chain: 'Polygon' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official name of this chain is Mumbai:

Suggested change
{ key: 'polygon-goerli', label: 'Polygon Goerli', chain: 'Polygon' }
{ key: 'polygon-mumbai', label: 'Polygon Mumbai', chain: 'Polygon' }

packages/api/src/typeDefs.ts Show resolved Hide resolved
packages/api/src/utils/index.ts Outdated Show resolved Hide resolved
packages/ui/components/FeedCard.vue Outdated Show resolved Hide resolved
packages/ui/utils/formatNumber.js Outdated Show resolved Hide resolved
Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabaldon gabaldon merged commit f378c97 into witnet:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid the need to create index in the code
4 participants