-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
package.json
Outdated
@@ -80,10 +80,11 @@ | |||
"draft-js-drag-n-drop-plugin": "2.0.0-rc9", | |||
"draft-js-embed-plugin": "^1.2.0", | |||
"draft-js-focus-plugin": "2.0.0-rc2", | |||
"draft-js-fork-mxstbr": "npm:draft-js-fork-mxstbr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That happened automatically...should that not be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I guess
Ah, now all tests are failing! |
Discussion here, but can't grok a clear solution: jestjs/jest#5119 |
Updating jest didn't seem to work |
Looks like possibly conflicting test environments for our static tests and create-react-app? |
I've attempted to swap out jest for jest-cli, updated deps in iris/package.json, but still nothing. Ref jestjs/jest#5401 |
People are saying to downgrade jest to 20.0.4, but that breaks because we need features that were introduced in jest 22.0.x lol cc @mxstbr |
What the fuck, tests work perfectly fine for me locally on the |
Can repro locally now |
This was the problem: jestjs/jest#5119 (comment) Fixed by ignoring the Jest from |
Status
Deploy after merge (delete what needn't be deployed)