Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flash attention #264

Merged
merged 3 commits into from
Jul 5, 2024
Merged

feat: flash attention #264

merged 3 commits into from
Jul 5, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jul 5, 2024

Description of change

  • feat: flash attention
  • feat: exclude GPU types from gpu: "auto"

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto July 5, 2024 16:16
@giladgd giladgd self-assigned this Jul 5, 2024
ido-pluto
ido-pluto approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit c2e322c into beta Jul 5, 2024
11 checks passed
@giladgd giladgd deleted the gilad/flashAttention branch July 5, 2024 16:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🎉 This PR is included in version 3.0.0-beta.37 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited by giladgd
Loading

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels
released on @beta released
Projects
node-llama-cpp: roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @ido-pluto