Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Llama 3 support #205

Merged
merged 10 commits into from
Apr 24, 2024
Merged

feat: Llama 3 support #205

merged 10 commits into from
Apr 24, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Apr 23, 2024 •
edited
Loading

Description of change

  • feat: Llama 3 support
  • feat: --gpu flag in generation CLI commands
  • feat: specialTokens parameter for model.detokenize
  • fix: FunctionaryChatWrapper bugs
  • fix: function calling syntax bugs
  • fix: show GPU layers in the Model line in CLI commands
  • refactor: rename LlamaChatWrapper to Llama2ChatWrapper

Fixes #204

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto April 23, 2024 23:51
@giladgd giladgd self-assigned this Apr 23, 2024
@giladgd giladgd linked an issue Apr 24, 2024 that may be closed by this pull request
Function call error #204
Closed
3 tasks
ido-pluto
ido-pluto approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit ef501f9 into beta Apr 24, 2024
12 checks passed
@giladgd giladgd deleted the gilad/wrapperImprovements branch April 24, 2024 16:28
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@giladgd giladgd mentioned this pull request Apr 24, 2024
Merged
17 tasks
@giladgd giladgd mentioned this pull request Jul 28, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited by giladgd
Loading

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels
released on @beta released
Projects
node-llama-cpp: roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function call error
2 participants
@giladgd @ido-pluto