Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social icons to mobile menu footer #988

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Add social icons to mobile menu footer #988

merged 6 commits into from
Nov 1, 2023

Conversation

magicDGS
Copy link
Contributor

NOTE: taking part in hacktoberfest

What kind of changes does this PR include?

  • Changes to Starlight code

Description

Visual changes
  • Before:
    imagen
  • After:
    imagen

@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit b7bb16b
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6542cfa59285e000084cb3a5
😎 Deploy Preview https://deploy-preview-988--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Oct 25, 2023
astrobot-houston
astrobot-houston reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@HiDeoo
Copy link
Member

HiDeoo commented Oct 25, 2023

Thanks for the pull request 🙌

On a purely visual level, it looks like in the preview shared in #978, the <ThemeSelect/> component is always next to the <LanguageSelect/> one whereas now, it seems we get equal spacing between the 3 components. I'm not sure if that's intentional or not, but I thought I'd mention it.

I think the entire mobile-preferences could use some gap between the components too:

SCR-20231025-tsdc

I am also not sure what should be the wrapping behavior here, it looks there is no wrapping at all at the moment.

delucis
delucis requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magicDGS! A few suggestions here to make this more closely match our design mock-up.

packages/starlight/components/MobileMenuFooter.astro Show resolved Hide resolved
packages/starlight/components/MobileMenuFooter.astro Show resolved Hide resolved
packages/starlight/components/MobileMenuFooter.astro Show resolved Hide resolved
@magicDGS @delucis
Apply suggestions from code review
28954a0 
Co-authored-by: Chris Swithinbank <[email protected]>
@magicDGS
Copy link
Contributor Author

Thanks a lot for the review and suggestions, @delucis! I added all of them an now looks much better, even on a viewpoint of 280px with a lot of icons:

imagen

Back to you for review!

@magicDGS magicDGS requested a review from delucis October 27, 2023 05:53
@delucis delucis added the 🌟 minor Change that triggers a minor release label Oct 31, 2023
@delucis delucis added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Nov 1, 2023
delucis
delucis approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the initiative with this one @magicDGS! I took care of those last few details so we can get this out in our next release 🌟

@delucis delucis changed the title fix: Add social icons to MobileMenuFooter.astro Add social icons to mobile menu footer Nov 1, 2023
@delucis delucis merged commit 977fe13 into withastro:main Nov 1, 2023
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 1, 2023
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 2, 2023
@HiDeoo
Merge branch 'main' into hd-docs-languages-refactor
0ad5d8c 
* main: (22 commits)
  fix(docs-i18n-tracker): update `translations` import (withastro#1025)
  [ci] format
  i18n(zh-cn): Update css-and-tailwind.mdx (withastro#1018)
  [ci] format
  i18n(zh-cn): Update authoring-content.md (withastro#1016)
  i18n(ko-KR): update `configuration.mdx` (withastro#1015)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1014)
  i18n(ko-KR): update `i18n.mdx` (withastro#1013)
  [ci] format
  i18n(ko-KR): update `frontmatter.md` (withastro#1017)
  [ci] format
  i18n(pt-BR): Update `css-and-tailwind.mdx`, `authoring-content.md` and `overrides.md` (withastro#1009)
  [ci] format
  [ci] release (withastro#996)
  Fix Prettier-compatibility of i18n test fixture
  Refactor translation system to be reusable in non-Astro code (withastro#1003)
  Add social icons to mobile menu footer (withastro#988)
  [ci] format
  Add Galician language support (withastro#1004)
  feat: add support for light / dark hero images (withastro#280)
  ...
@magicDGS
Copy link
Contributor Author

magicDGS commented Nov 7, 2023

Thanks a lot for merging the PR. I am soglad that I have contributed and I hope to keep doing it in the future, as I am planning to adopt starlight for one of my current personal projects even if not yet on v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrobot-houston astrobot-houston astrobot-houston left review comments

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest 🌟 minor Change that triggers a minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc template on mobile unable to access social menu
4 participants
@magicDGS @HiDeoo @delucis @astrobot-houston