Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instagram icon #499

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Add Instagram icon #499

merged 10 commits into from
Aug 14, 2023

Conversation

D3vil0p3r
Copy link
Contributor

What kind of changes does this PR include?

  • Instagram icon added.

Description

  • The PR will add the Instagram icon that can be mainly used on the top bar.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3fdf6d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3fdf6d9
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64da5ddbc60f2e0007c0e7f5
😎 Deploy Preview https://deploy-preview-499--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Aug 11, 2023
@github-actions github-actions bot added the 📚 docs Documentation website changes label Aug 11, 2023
@D3vil0p3r D3vil0p3r marked this pull request as ready for review August 11, 2023 14:47
delucis
delucis reviewed Aug 12, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great — thanks for the PR @D3vil0p3r!

I just have one small suggestion to optimize the icon path and this should be good to go.

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
@D3vil0p3r
Copy link
Contributor Author

This looks great — thanks for the PR @D3vil0p3r!

I just have one small suggestion to optimize the icon path and this should be good to go.

Thank you for the suggestion!

delucis
delucis approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @D3vil0p3r! We’ll get this out in the next patch release 🥳

@delucis delucis added the 🌟 patch Change that triggers a patch release label Aug 12, 2023
@delucis delucis changed the title Adding Instagram icon Add Instagram icon Aug 14, 2023
@delucis delucis merged commit fcff49e into withastro:main Aug 14, 2023
@astrobot-houston astrobot-houston mentioned this pull request Aug 14, 2023
Merged
@D3vil0p3r D3vil0p3r deleted the main-1 branch August 14, 2023 20:38
This was referenced Aug 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D3vil0p3r @delucis