Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update wrong links #2524

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix: update wrong links #2524

merged 4 commits into from
Oct 29, 2024

Conversation

jsparkdev
Copy link
Contributor

@jsparkdev jsparkdev commented Oct 29, 2024 •
edited
Loading

Description

update wrong links

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2cf0b73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Oct 29, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 2cf0b73
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6720db06fd3e9800083eea10
😎 Deploy Preview https://deploy-preview-2524--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/i18n.mdx Source changed, localizations will be marked as outdated.
en reference/overrides.md Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev jsparkdev mentioned this pull request Oct 29, 2024
Merged
@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Oct 29, 2024
@jsparkdev jsparkdev changed the title fix: update wrong link in i18n.mdx fix: update wrong links Oct 29, 2024
liruifengv
liruifengv approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! @jsparkdev

@liruifengv liruifengv mentioned this pull request Oct 29, 2024
Merged
delucis
delucis approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great work spotting those @jsparkdev! Thank you 💖

@delucis delucis merged commit 1b46783 into withastro:main Oct 29, 2024
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 29, 2024
Merged
trueberryless added a commit to trueberryless/withastro-starlight that referenced this pull request Oct 29, 2024
@trueberryless
fix links withastro#2524
4025841
This was referenced Oct 29, 2024
Merged
Merged
@jsparkdev jsparkdev deleted the fix-i18n-link branch October 29, 2024 13:23
@jsparkdev jsparkdev mentioned this pull request Oct 29, 2024
Merged
thomasbnt added a commit to thomasbnt/starlight that referenced this pull request Oct 29, 2024
@thomasbnt
i18n(fr): Update guides/i18n.mdx from withastro#2524
43fd19d
@thomasbnt thomasbnt mentioned this pull request Oct 29, 2024
Merged
thomasbnt added a commit to thomasbnt/starlight that referenced this pull request Oct 29, 2024
@thomasbnt
i18n(fr): Update reference/overrides.mdx from withastro#2524
6954033
@thomasbnt thomasbnt mentioned this pull request Oct 29, 2024
Merged
HiDeoo added a commit that referenced this pull request Oct 30, 2024
@thomasbnt @HiDeoo @dreyfus92
i18n(fr): Update reference/overrides.mdx from #2524 (#2538)
317244a 
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: dreyfus92 <[email protected]>
HiDeoo added a commit that referenced this pull request Oct 30, 2024
@thomasbnt @HiDeoo @dreyfus92
i18n(fr): Update guides/i18n.mdx from #2444 and #2524 (#2536)
67c95ef 
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: dreyfus92 <[email protected]>
@morinokami morinokami mentioned this pull request Nov 4, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruifengv liruifengv liruifengv approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsparkdev @astrobot-houston @delucis @liruifengv