Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2166

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Update dependencies #2166

merged 1 commit into from
Aug 5, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Aug 5, 2024

Description

  • Updates dependencies of the main Starlight package
  • Main intention is to update Expressive Code, which fixed the emitFile() warning logs in v0.35.5
  • I initially tried updating more but ran into a couple of CI issues so decided to scale back the scope to get the EC change in

Note for the future from @HiDeoo: initial failures may have been because the E2E test fixtures hadn’t had their deps updated to match. May want to include those in the pnpm workspace (if possible for a nested directory)?

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: a6e7174

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package 🌟 tailwind Changes to Starlight’s Tailwind package labels Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit a6e7174
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66b1050aff38760008953a5e
😎 Deploy Preview https://deploy-preview-2166--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Aug 5, 2024

size-limit report 📦

Path Size
/index.html 5.95 KB (0%)
/_astro/*.js 21.93 KB (-0.01% 🔽)
/_astro/*.css 13.81 KB (+0.15% 🔺)

@delucis delucis added the 🌟 patch Change that triggers a patch release label Aug 5, 2024
@github-actions github-actions bot removed 📚 docs Documentation website changes 🌟 tailwind Changes to Starlight’s Tailwind package labels Aug 5, 2024
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me, and that warning gone is a great DX improvement even if everything was working as intended 👍

@delucis delucis merged commit 4f12049 into main Aug 5, 2024
15 checks passed
@delucis delucis deleted the chris/deps branch August 5, 2024 17:24
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 6, 2024
* main: (275 commits)
  [ci] release (withastro#2165)
  Define well-known RTL locales before calling `getLocaleInfo()` for default locale (withastro#2167)
  Update dependencies (withastro#2166)
  Improve page load performance (withastro#2155)
  docs: Add CodeSweetly to showcase (withastro#2160)
  [ci] release (withastro#2145)
  Fix bug for projects with spaces in their pathname (withastro#2156)
  ci: update file icons (withastro#2157)
  [ci] format
  Merge <link rel="canonical" /> tags, quick fixes (withastro#2153) (withastro#2154)
  Add two new showcase sites (withastro#2149)
  [ci] format
  i18n(zh-cn): Update `environmental-impact.md` (withastro#2148)
  add Saasfly showcase (withastro#2147)
  docs: add 'og:image:alt' metadata (withastro#2143)
  Deleting unnecessary twitter meta tags, quick fixes (withastro#2137)
  [ci] format
  i18n(es): update `environmental-impact` (withastro#2144)
  [ci] release (withastro#2142)
  feat: Add Pinterest icon to social list (withastro#2135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants