Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style code, hr and blockquote within asides #2119

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

evadecker
Copy link
Contributor

@evadecker evadecker commented Jul 10, 2024

Description

Dark Mode:

Before After
CleanShot 2024-07-10 at 00 04 16@2x CleanShot 2024-07-10 at 00 33 14@2x
CleanShot 2024-07-10 at 00 05 25@2x CleanShot 2024-07-10 at 00 33 44@2x
CleanShot 2024-07-10 at 00 05 37@2x CleanShot 2024-07-10 at 00 34 15@2x
CleanShot 2024-07-10 at 00 05 47@2x CleanShot 2024-07-10 at 00 34 43@2x

Light Mode:

Before After
CleanShot 2024-07-10 at 00 06 04@2x CleanShot 2024-07-10 at 00 34 50@2x
CleanShot 2024-07-10 at 00 06 26@2x CleanShot 2024-07-10 at 00 34 56@2x
CleanShot 2024-07-10 at 00 06 42@2x CleanShot 2024-07-10 at 00 35 03@2x
CleanShot 2024-07-10 at 00 06 54@2x CleanShot 2024-07-10 at 00 35 10@2x

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 4455f1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jul 10, 2024 4:16pm

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4455f1f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/668eb372ee32fc0008ff05e5
😎 Deploy Preview https://deploy-preview-2119--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Jul 10, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/asides-test.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@OliverSpeir OliverSpeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@evadecker evadecker changed the title Style markdown within asides Style code, hr and blockquote within asides Jul 10, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, love how little code you needed to make this improvement — nice work @evadecker!

I actually think we can consider this a “bug fix” rather than a minor, so will update the changeset to reflect that.

I think this is the case with this PR and I think you’re aware already, but just noting for the record that the color-mix() styles won’t be available in all our supported browsers, but given this is an incremental improvement, I think that’s quite OK.

.changeset/tender-fishes-join.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 📚 docs Documentation website changes label Jul 10, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s get these styles on the road! 🚀

@delucis delucis merged commit 464685a into withastro:main Jul 10, 2024
17 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 10, 2024
@evadecker evadecker deleted the aside-code branch July 10, 2024 16:36
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Jul 11, 2024
* main:
  [ci] release (withastro#2110)
  Style `code`, `hr` and `blockquote` within asides (withastro#2119)
  Fix an Astro i18n → Starlight i18n config conversion issue (withastro#2122)
  Add Starlight Examples to community content page (withastro#2109)
  added feedbackspark in showcase. (withastro#2116)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#2114)
  i18n(zh-cn): Update `configuration.mdx` (withastro#2113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aside styling of code, blockquote, and hr could be improved
4 participants