-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style code
, hr
and blockquote
within asides
#2119
Conversation
🦋 Changeset detectedLatest commit: 4455f1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
code
, hr
and blockquote
within asides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, love how little code you needed to make this improvement — nice work @evadecker!
I actually think we can consider this a “bug fix” rather than a minor, so will update the changeset to reflect that.
I think this is the case with this PR and I think you’re aware already, but just noting for the record that the color-mix()
styles won’t be available in all our supported browsers, but given this is an incremental improvement, I think that’s quite OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s get these styles on the road! 🚀
* main: [ci] release (withastro#2110) Style `code`, `hr` and `blockquote` within asides (withastro#2119) Fix an Astro i18n → Starlight i18n config conversion issue (withastro#2122) Add Starlight Examples to community content page (withastro#2109) added feedbackspark in showcase. (withastro#2116) i18n(zh-cn): Update `sidebar.mdx` (withastro#2114) i18n(zh-cn): Update `configuration.mdx` (withastro#2113)
Description
Aside
styling ofcode
,blockquote
, andhr
could be improved #2118code
and the border color ofhr
andblockquote
when placed within anAside
Dark Mode:
Light Mode: