Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor <Steps> counter #2041

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Jun 19, 2024

Description

A new attempt at fixing <Steps> counter using a custom counter.

This PR is a draft as I just wanted a preview URL to share. If the approach is working and accepted, tests would need to be updated and a changeset to be added.

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: d3f5d4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jun 20, 2024 6:05pm

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jun 19, 2024
@astrobot-houston
Copy link
Collaborator

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/steps.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

Tested in Chrome 126, Safari, and Firefox on macOS without issues. Maybe worth testing on Windows if someone is able? I think we had issues with Windows on the previous fix.

packages/starlight/user-components/rehype-steps.ts Outdated Show resolved Hide resolved
@lorenzolewis
Copy link
Contributor

Tested on Safari on iOS 17.5.1 (21F90) and LGTM!

@liruifengv
Copy link
Member

Tested in Chrome, Edge and Firefox on Windows11, works perfect!

@delucis
Copy link
Member

delucis commented Jun 20, 2024

Thanks for testing @lorenzolewis and @liruifengv! I know @HiDeoo may have less time to work on this and I feel like the bug is relatively urgent, so will take over this PR now and polish it up for release.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jun 20, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for figuring out this fix @HiDeoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Steps> Numbers out of order
5 participants