-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor <Steps>
counter
#2041
Refactor <Steps>
counter
#2041
Conversation
🦋 Changeset detectedLatest commit: d3f5d4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
Tested in Chrome 126, Safari, and Firefox on macOS without issues. Maybe worth testing on Windows if someone is able? I think we had issues with Windows on the previous fix.
Tested on Safari on iOS 17.5.1 (21F90) and LGTM! |
Tested in Chrome, Edge and Firefox on Windows11, works perfect! |
Thanks for testing @lorenzolewis and @liruifengv! I know @HiDeoo may have less time to work on this and I feel like the bug is relatively urgent, so will take over this PR now and polish it up for release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for figuring out this fix @HiDeoo!
Description
<Steps>
Numbers out of order #2032A new attempt at fixing
<Steps>
counter using a custom counter.This PR is a draft as I just wanted a preview URL to share. If the approach is working and accepted, tests would need to be updated and a changeset to be added.