-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /
search shortcut
#2025
Remove /
search shortcut
#2025
Conversation
🦋 Changeset detectedLatest commit: aa92b0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the research and work on this @HiDeoo! I had a couple of small questions/suggestions, but generally seems really solid. I appreciate the screen reader videos!
cc @markteekman on this one too as the original issue author
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Suggesting one small translation change, but all the code changes seem spot on. Thank you @HiDeoo 🚀
Co-authored-by: Chris Swithinbank <[email protected]>
Description
This PR removes the
/
search shortcut for accessibility reasons.We cannot entirely rely on
aria-keyshortcuts
to indicate the presence of the search shortcut due to its poor support in screen readers. The markup was slightly updated to get the best out of it.Here is a video of the behavior with VoiceOver on macOS:
voiceover.mp4
Here is a video of the behavior with NVDA on Windows:
nvda.mp4