Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Update configuration & sidebar #1029

Merged
merged 4 commits into from
Nov 2, 2023
Merged

i18n(es): Update configuration & sidebar #1029

merged 4 commits into from
Nov 2, 2023

Conversation

dreyfus92
Copy link
Member

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

  • What does this PR change? Give us a brief description.
    Updated configuration & sidebar based on these 2 commits 5bf4457 & dcb5f7a

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e36f94f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit e36f94f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/654404b8e9d9ae0007731ece
😎 Deploy Preview https://deploy-preview-1029--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 2, 2023
kevinzunigacuellar
kevinzunigacuellar reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @dreyfus92 💜 , la unica observacion es borrar el badge config extra de la configuracion antigua

@dreyfus92
Copy link
Member Author

Muchas gracias por la revisión @kevinzunigacuellar 😁

@kevinzunigacuellar
Copy link
Member

LGTM! Thanks @dreyfus92

@kevinzunigacuellar kevinzunigacuellar merged commit 5318543 into withastro:main Nov 2, 2023
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 5, 2023
@HiDeoo
Merge branch 'main' into hd-plugins
6da9b51 
* main: (103 commits)
  i18n(fr): update `guides/sidebar.mdx` (withastro#1033)
  i18n(fr): update `reference/configuration.mdx` (withastro#1034)
  i18n(fr): update `reference/frontmatter.md` (withastro#1035)
  Fix docs component details (withastro#1031)
  Overhaul getting started guide (withastro#1026)
  i18n(zh-cn): Update sidebar.mdx & configuration.mdx (withastro#1022)
  i18n(es): Update `configuration` & `sidebar` (withastro#1029)
  [ci] format
  i18n(zh-cn): Update frontmatter.md (withastro#1020)
  i18n(zh-cn): Update overrides.md (withastro#1021)
  i18n(zh-cn): Update i18n.mdx (withastro#1019)
  fix(docs-i18n-tracker): update `translations` import (withastro#1025)
  [ci] format
  i18n(zh-cn): Update css-and-tailwind.mdx (withastro#1018)
  [ci] format
  i18n(zh-cn): Update authoring-content.md (withastro#1016)
  i18n(ko-KR): update `configuration.mdx` (withastro#1015)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1014)
  i18n(ko-KR): update `i18n.mdx` (withastro#1013)
  [ci] format
  ...
@dreyfus92 dreyfus92 deleted the updates-61 branch April 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar left review comments

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreyfus92 @kevinzunigacuellar