CDN support #545
Merged
CDN support #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2023
FredKSchott
approved these changes
Apr 1, 2023
|
|
||
| # Unresolved Questions | ||
|
|
||
| 1. Is the `build.assetsPrefix` name fine? I picked it to complement the existing `build.assets` option. `build.cdnUrl` feels "sticking out". |
There was a problem hiding this comment.
That feels fine to me. A bit odd that it's assetsPrefix instead of Next's assetPrefix but I get that matching build.assets is probably more important.
|
This looks awesome! I think it would be a massive win to serve assets from a CDN for larger projects using Astro. The only thing I would add is perhaps some sort of section that outlines a checklist of all major CDNs that will be tested to ensure they work with this newly purposed feature.
|
|
Tested with Cloudflare and it seems to work: https://github.com/bluwy/astro-cdn-test and https://bluwy.github.io/astro-cdn-test/. The core workings is the same so I'd expect it to work in other platforms too as long as the links are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC adds CDN support through the
build.assetsPrefixoption. Allowing sites to fetch all assets from an external CDN.Links