API route proposed changes

[matthewp]

• Start Date: 2022-04-25
• Status: Draft

Summary

Change the signature for API routes into a single APIContext argument, allowing you to use destructing to get the properties you want:

export async function get({ params, request }) {
  if(!request.headers.has('cookie')) {
    return new Response(null, {
      status: 301,
      headers: {
        Location: '/'
      }
    });
  }

  // ...
}

Links

• Full Rendered Proposal

[matthewp]

Feedback from the call:

• Could be helped by showing what other frameworks do here.
• Some people prefer request as the first arg and an APIContext as the second. Want to see how people respond.

[FredKSchott]

+1 LGTM

Thanks for taking the extra time to flesh this out, it's nice to see that others are also using the single-argument approach and I agree that that feels like the right path forward.

[Princesseuh]

Looks good! I especially really like the APIRoute way of typing the route

[matthewp]

This was accepted!