Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribute the language server and related packages as ESM #962

Closed
wants to merge 1 commit into from

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Oct 4, 2024

Changes

VS Code famously does not support ESM inside extensions, however, this does not prevent us from publishing everything related as ESM, as other editors can support it just fine.

This PR migrates everything apart from two packages:

  • The VS Code extension (duh)
  • The TypeScript plugin
    • I couldn't figure it out, if I wrote it as ESM, but converted it to CJS with esbuild TSServer complained that the plugin was wrongly shaped. Looking around the ecosystem, everyone seems to write them as CJS so, oh well.

This PR also updates other packages, I had a weird problem with something not being able to understand the syntax, so just went ahead and updated every devDeps.

Testing

I tried it manually, it's very possible that as publish time everything break though.

Docs

N/A

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: ff1fb55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Princesseuh
Copy link
Member Author

This is proving to be way too complicated, will wait a bit more...

@Princesseuh Princesseuh closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant