Add support for inlay hints #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ffd285e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
added
the
ecosystem: upstream
Princesseuh
removed
the
ecosystem: upstream
Princesseuh
changed the title
matthewp
approved these changes
May 11, 2022
Princesseuh
commented
May 12, 2022
Comment on lines
+258
to
+261
| if (data.originalItem.source) { | ||
| item.labelDetails = { description: data.originalItem.source }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Just a quick fix since we now support label details with the latest version of LSP, we also need to set it when resolving imports otherwise the resolved import label details will be empty
Princesseuh
added a commit
that referenced
this pull request
May 19, 2022
This reverts commit 09e1163.
Princesseuh
added a commit
that referenced
this pull request
May 19, 2022
Princesseuh
added a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for inlay hints! This requires upgrading the versions of a few things as inlay hints support was only added in the latest version of the LSP. Those versions are stable, as they've been through a lot of testing (and are already in use by other extensions)
Testing
Tests added
Docs
No docs needed, inlayHints are enabled using the same configuration they're enabled with in TypeScript files