Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ja): Update directives-reference.mdx translation #9863

Merged
merged 3 commits into from
Oct 30, 2024
Merged

i18n(ja): Update directives-reference.mdx translation #9863

merged 3 commits into from
Oct 30, 2024

Conversation

arrow2nd
Copy link
Contributor

Description (required)

The Japanese translation page is missing a section on fallback, and I had a little trouble with it, so I added it.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

First-time contributor to Astro Docs?

arrow2nd

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 29, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e9524d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6722573ebc509f00080b33c7
😎 Deploy Preview https://deploy-preview-9863--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja reference/directives-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

morinokami
morinokami reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arrow2nd 翻訳に参加いただきありがとうございます！いただいた訳についてコメントした一点を除き問題はなさそうなのですが、このドキュメントは他にも翻訳が必要な箇所が存在するようです。具体的には、https://github.com/withastro/docs/commits/main/src/content/docs/en/reference/directives-reference.mdx?since=2024-08-06T17:00:53.000Z の

が未翻訳のようです。Astro の翻訳状況は https://i18n.docs.astro.build/ にて管理されており、英語版との最終更新日時での比較により翻訳が要修正かを判断しています。その関係上、未翻訳のものがある状態でこのドキュメントを更新してしまうと、「翻訳が必要であるにも関わらず翻訳不要」とマークされてしまうため、なるべくなら翻訳が必要な箇所をすべてここで対応いただきたいのですが、上の 2 件について対応は可能でしょうか？（無理であればこちらで引き継ぎますので、遠慮なく言ってもらって大丈夫です！）

src/content/docs/ja/reference/directives-reference.mdx Outdated
Comment on lines 201 to 202
クライアントでのみレンダリングするコンポーネントでは、読み込み中にフォールバックコンテンツを表示することが可能です。
子要素で `slot="fallback"` を使用すると、クライアントコンポーネントが利用可能になるまで表示される要素を指定できます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここなのですが、英語版と同様に改行してしまうとスクショのように無駄なスペースが発生してしまうため、段落内は改行しないようお願いします。また、この翻訳版では英単語やインラインコードの周囲に半角スペースを入れないという規則になっているため、その削除もお願いします🙏

Screenshot 2024-10-30 at 0 17 16
Suggested change
クライアントでのみレンダリングするコンポーネントでは、読み込み中にフォールバックコンテンツを表示することが可能です。
子要素で `slot="fallback"` を使用すると、クライアントコンポーネントが利用可能になるまで表示される要素を指定できます。
クライアントでのみレンダリングするコンポーネントでは、読み込み中にフォールバックコンテンツを表示することが可能です。子要素で`slot="fallback"`を使用すると、クライアントコンポーネントが利用可能になるまで表示される要素を指定できます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！こちら修正しました

morinokami
morinokami approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応いただきありがとうございました、LGTM！

yanthomasdev
yanthomasdev approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job! And welcome to Team Docs! 🙌

@yanthomasdev yanthomasdev merged commit c00113c into withastro:main Oct 30, 2024
10 checks passed
@arrow2nd arrow2nd deleted the patch-1 branch October 30, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@morinokami morinokami morinokami approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arrow2nd @astrobot-houston @morinokami @yanthomasdev