Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdx] Adds usage information, taken out of the Markdown guide #9337

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Sep 7, 2024

Description (required)

Separates some content out from the Markdown page and puts it on the MDX page and the troubleshooting page.

I can't make the corresponding Markdown page changes here/yet because that's a lot of link resolving that I've already fixed on the beta docs branch. 😄

So that means this content will be duplicated until I can resolve them, but I think that's fine. It will give translators a chance to translate these early, and when the Markdown page is updated with content removed, it won't be a problem.

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 58cd243
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66dcd1f671cf2900080be6c9
😎 Deploy Preview https://deploy-preview-9337--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/mdx.mdx Source changed, localizations will be marked as outdated.
en guides/troubleshooting.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 changed the title [mdx] Adds usage information from the Markdown guide page [mdx] Adds usage information, taken out of the Markdown guide Sep 7, 2024
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just notice two typo and one nitpicking. I also left a suggestion about a section which bothered me at first reading (but I'm not sure my suggestion is better).

src/content/docs/en/guides/integrations-guide/mdx.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/mdx.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/mdx.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/mdx.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 merged commit 582c0ee into main Sep 7, 2024
10 checks passed
@sarah11918 sarah11918 deleted the mdx-sarah branch September 7, 2024 22:38
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Sep 9, 2024
yanthomasdev added a commit that referenced this pull request Sep 11, 2024
* i18n(fr): Update `guides/integrations-guide/mdx.mdx` from #9337

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `guides/integrations-guide/mdx.mdx` from #9344

Signed-off-by: Thomas Bonnet <[email protected]>

* Fix typo `<Content />`

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/integrations-guide/mdx.mdx

Co-authored-by: Armand Philippot <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Yan <[email protected]>
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 14, 2024
thomasbnt pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants