-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdx] Adds usage information, taken out of the Markdown guide #9337
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just notice two typo and one nitpicking. I also left a suggestion about a section which bothered me at first reading (but I'm not sure my suggestion is better).
Co-authored-by: Armand Philippot <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]>
* i18n(fr): Update `guides/integrations-guide/mdx.mdx` from #9337 Signed-off-by: Thomas Bonnet <[email protected]> * i18n(fr): Update `guides/integrations-guide/mdx.mdx` from #9344 Signed-off-by: Thomas Bonnet <[email protected]> * Fix typo `<Content />` Signed-off-by: Thomas Bonnet <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> * Update src/content/docs/fr/guides/integrations-guide/mdx.mdx Co-authored-by: Armand Philippot <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Armand Philippot <[email protected]> Co-authored-by: Yan <[email protected]>
Description (required)
Separates some content out from the Markdown page and puts it on the MDX page and the troubleshooting page.
I can't make the corresponding Markdown page changes here/yet because that's a lot of link resolving that I've already fixed on the beta docs branch. 😄
So that means this content will be duplicated until I can resolve them, but I think that's fine. It will give translators a chance to translate these early, and when the Markdown page is updated with content removed, it won't be a problem.