Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference where scripts are hoisted #9288

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 2, 2024

Description (required)

In Astro 5, scripts are no longer hoisted to the head. We should avoid mentioning so.

Implementation PR: withastro/astro#11791

PLT-2086

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.x. See astro PR withastro/astro#11791.

@bluwy bluwy added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) 5.0.0-beta labels Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 8964e4c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66d9eb3aa2f27200071f102f
😎 Deploy Preview https://deploy-preview-9288--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Sep 5, 2024
@sarah11918 sarah11918 merged commit c590ad5 into 5.0.0-beta Sep 5, 2024
4 of 5 checks passed
@sarah11918 sarah11918 deleted the update-direct-render-script-change branch September 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0.0-beta improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants