Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Update api-reference.mdx,configuration-reference.mdx #7866

Merged
merged 29 commits into from
Apr 12, 2024
Merged

i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Update api-reference.mdx,configuration-reference.mdx #7866

merged 29 commits into from
Apr 12, 2024

Conversation

huyikai
Copy link
Contributor

@huyikai huyikai commented Apr 12, 2024 •
edited
Loading

Description (required)

Create internationalization.mdx
Create incorrect-strategy-for-i18n.mdx
Update api-reference.mdx
Update configuration-reference.mdx

Related issues & labels (optional)

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 12, 2024 9:48am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 12, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 12, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note Locale
src/content/docs/zh-cn/guides/internationalization.mdx Localization added, will be marked as complete. zh-cn
src/content/docs/zh-cn/reference/api-reference.mdx Localization changed, will be marked as complete. zh-cn
src/content/docs/zh-cn/reference/configuration-reference.mdx Localization changed, will be marked as complete. zh-cn
src/content/docs/zh-cn/reference/errors/incorrect-strategy-for-i18n.mdx Localization added, will be marked as complete. 🔄️ zh-cn
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@huyikai huyikai changed the title i18n(zh-cn): Create internationalization.mdx i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Apr 12, 2024
@huyikai huyikai changed the title i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Update api-reference.mdx Apr 12, 2024
@liruifengv liruifengv mentioned this pull request Apr 12, 2024
Closed
liruifengv
liruifengv reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration-reference.mdx 有很多更新，似乎没有更新上来？

@huyikai
Copy link
Contributor Author

huyikai commented Apr 12, 2024

configuration-reference.mdx 有很多更新，似乎没有更新上来？

Translation status 里没有看到 configuration-reference.mdx 的更新。我这个修改是处理它的坏链。 我去翻一下这个文件的上游看看。

@huyikai
Copy link
Contributor Author

huyikai commented Apr 12, 2024

configuration-reference.mdx 有很多更新，似乎没有更新上来？

我看到了。我补充一下

liruifengv
liruifengv reviewed Apr 12, 2024
View reviewed changes
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/internationalization.mdx Outdated Show resolved Hide resolved
@huyikai huyikai changed the title i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Update api-reference.mdx i18n(zh-cn): Create internationalization.mdx,incorrect-strategy-for-i18n.mdx Update api-reference.mdx,configuration-reference.mdx Apr 12, 2024
liruifengv
liruifengv approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@liruifengv liruifengv added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 12, 2024
@liruifengv liruifengv merged commit 74334e2 into withastro:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruifengv liruifengv liruifengv approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huyikai @astrobot-houston @liruifengv