Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-tw): update project-structure.mdx translation #7133

Merged
merged 5 commits into from
Mar 5, 2024
Merged

i18n(zh-tw): update project-structure.mdx translation #7133

merged 5 commits into from
Mar 5, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Mar 2, 2024 •
edited
Loading

Description

  • Updates Traditional Chinese translation of src/content/docs/zh-tw/basics/project-structure.mdx

Related issues & labels

  • Closes #
  • Suggested label: i18n

@vercel Vercel
Copy link

vercel bot commented Mar 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 5, 2024 3:48am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 2, 2024
liruifengv
liruifengv reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to comment on the specified line.
There are some little issues.
Does components in the page need to be changed to 元件?

image

There's no translation in English here.

@mingjunlu
Copy link
Contributor Author

I don't have a way to comment on the specified line. There are some little issues. Does components in the page need to be changed to 元件?

image

There's no translation in English here.

Thanks! I've translated the untranslated paragraph and improved translation consistency.

liruifengv
liruifengv approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Notice that this page uses FileTree. I'm trying to replace it with Starlight's FileTree in #7182.
But don't worry, I'll take care of these.

@liruifengv liruifengv added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 4, 2024
dreyfus92
dreyfus92 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you peeps, LGTM ✅

@dreyfus92 dreyfus92 merged commit 307e3cf into withastro:main Mar 5, 2024
7 checks passed
@mingjunlu mingjunlu deleted the zh-tw/project-structure branch March 5, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@liruifengv liruifengv liruifengv approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingjunlu @liruifengv @dreyfus92