Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18nIgnore] feat(image-service-reference): Change types to Uint8Array #5326

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[i18nIgnore] feat(image-service-reference): Change types to Uint8Array #5326

merged 2 commits into from
Nov 9, 2023

Conversation

Princesseuh
Copy link
Member

Description (required)

Documentation for withastro/astro#9029

99.99999% of people won't be affected by this change, nonetheless we'll document what you can do if you are affected in the changeset.

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 1870585
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654d63d24e960e00084d4b8e
😎 Deploy Preview https://deploy-preview-5326--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Princesseuh Princesseuh mentioned this pull request Nov 9, 2023
Merged
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 9, 2023
sarah11918
sarah11918 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! and removed improve documentation Enhance existing documentation (e.g. add an example, improve description) labels Nov 9, 2023
@sarah11918 sarah11918 changed the title feat(image-service-reference): Change types to Uint8Array [i18nIgnore] feat(image-service-reference): Change types to Uint8Array Nov 9, 2023
@sarah11918 sarah11918 merged commit e476b10 into main Nov 9, 2023
9 of 11 checks passed
@sarah11918 sarah11918 deleted the fix/uint8array-assets branch November 9, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Princesseuh @sarah11918