-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document locals
in adapter API
#3685
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @ematipico! I took a shot at using links to content we already have to see if this could work for the section. What do you think? Do you think this is complete enough?
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918 thank you for the review, everything looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, overall LGTM!
Co-authored-by: Yan Thomas <[email protected]>
@matthewp could you please advice on how we can explain |
Co-authored-by: Sarah Rainsberger <[email protected]>
That's a lot of stuff to document. Do we have any way to point that arg to a type that's defined? |
I was thinking to document only when/why an adapter can pass a |
@sarah11918 @Yan-Thomas added a small paragraph about the second optional parameter. |
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ematipico ! Nice to have an example here!
What kind of changes does this PR include?
Description
Relevant PR: withastro/astro#7385
This PR adds a new paragraph to the
app.render
heading. Unfortunately, I don't know enough to explain the second argument (routeData
), so I left aTODO
there.It would be great if we could document it in this PR, but I would need some help.