Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Collections guide #2141

Merged
merged 127 commits into from
Dec 16, 2022
Merged

Content Collections guide #2141

merged 127 commits into from
Dec 16, 2022

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Dec 6, 2022

What kind of changes does this PR include?

  • New or updated content

Description

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 7d7f235
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/639cdcd97f2b49000aedadaa
😎 Deploy Preview https://deploy-preview-2141--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Dec 6, 2022
@delucis delucis added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Dec 7, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @bholmesdev! Still need to get to the last part of this (“Generating pages…” and below) but er… this should be enough feedback to start off with 😅

src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
bholmesdev and others added 9 commits December 7, 2022 14:48
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a couple of small fixes. If we have time, one thing I’d do: reorg the “Rendering page content from entries” so that the intro paragraph covers render() in general (e.g. including headings) and the first subhead render() is focused on <Content />. At the moment we kind of have two sections describing <Content /> to introduce render() and then the other return types. A quick snippet that shows something like this could be handy:

const { Content, headings, injectedFrontmatter } = entry.render();

Running out the door but I can take a close look at doing that if it would be helpful.

src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
src/pages/en/guides/content-collections.md Outdated Show resolved Hide resolved
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hereby declare myself… CONTENT! 🥳

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me collect myself... and approve! 🥳

@sarah11918
Copy link
Member

🌲 💜

@delucis delucis merged commit 01bfb99 into main Dec 16, 2022
@delucis delucis deleted the new/content-schemas-guide branch December 16, 2022 21:06
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants