-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline support #1888
Offline support #1888
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
This reverts commit 0e61249.
7b8b30b
to
799949e
Compare
…into offline-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zadeviggers! Thanks so much for exploring this — it’s super cool and sorry we haven’t had time to really dive into reviewing this complex PR.
I’m wondering if you think we could use some existing packages out there to get some similar functionality? This is a lot of code we would need to maintain and debug in the future and it feels like maybe for some of it we could be re-using prior art from other packages.
Using external package was actually the first thing I tried. I tried |
Well @zadeviggers, sometimes these PRs just take time, and sometime they don't work out. We've discussed this a few times now, and we keep coming back to the issue of not wanting to take on the maintenance burden of a PWA. Especially now that we have Astro docs on devdocs.io, we have an offline option for readers with the added advantage of being higher profile and putting us up with a ton of other docs. So, we're closing this PR, BUT I do think a prominent link somewhere that these docs are available on devdocs.io would be a good idea for people who do want offline docs but don't know about it. Thank you for making sure this issue stayed on our minds, and the thought and attention you've given it. The final decision is that we're content to go with the devdocs.io solution for offline reading. |
Description
Work on adding opt-in, network-first (to keep content up-to-date), offline support to the docs site.
This is very much a WIP PR. There's still a lot of work to do before this is ready. I'm just creating this PR so that people have something to look at in the community call on Wednesday.
Big things still to do:
simple-vanilla-notifications
?FAQ: