[update] ssr adapter astro add instructions #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
commented
Sep 1, 2022
sarah11918
commented
Sep 1, 2022
sarah11918
commented
Sep 1, 2022
sarah11918
commented
Sep 1, 2022
sarah11918
commented
Sep 1, 2022
sarah11918
commented
Sep 1, 2022
yanthomasdev
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Thanks for this @sarah11918, I added a small suggestion! I'll hold my "LGTM" till we have an decision about dependencies or devDependencies.
yanthomasdev
added
the
improve or update documentation
Co-authored-by: Yan Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs currently only show manual instructions for adding SSR adapters. This updates all the (located in Docs repo) pages to first instruct using
npx astro addand then offer the current manual instructions (install the package, updateastro.config.mjs) as an alternative.Pages updated: SSR and all the deploy pages. (Integration package READMEs and
configuration-referencewill need to be updated atwithastro/astro.)NOTE: Current Maintainers discussion needs to be resolved first re: our general move to recommend
dependenciesoverdevDependenciesbecause ofastro add's behavior. These changes assume that manual installation instructions should NOT show installing as dev dependencies, to be consistent. But, sinceastro addcurrently DOES use the dev flag, we want to wait for a resolution before publishing these instructions.POSSIBLE CHANGES NEEDED: manual instructions might need to have the
--save-devflag added back if we decide these ARE to be installed as devDeps