Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Update Cloudflare docs to show adapter support #1254

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

Ekwuno
Copy link
Contributor

@Ekwuno Ekwuno commented Aug 10, 2022

What kind of changes does this PR include?

This PR Update Cloudflare's adapter usage in Astro docs

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • Closes #
  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c77ff97
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62f4498e23472a000803352c
😎 Deploy Preview https://deploy-preview-1254--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving our Cloudflare documentation @Ekwuno! Who better to provide it than the source? 😄

I've added some suggestions re: code formatting because we have some specific syntax we use to author our code samples. If you try those and double check, I think that will give you what you're after that fits with our current Docs style. (I actually have an open PR right now documenting this code authoring for our WRITING.md document, so if something is a little off, you could check there!) So see how it looks on your end, make sure it's giving you the code samples you expect, and let me know if you have any questions about this!

src/pages/en/guides/deploy/cloudflare.md Outdated Show resolved Hide resolved
src/pages/en/guides/deploy/cloudflare.md Outdated Show resolved Hide resolved
src/pages/en/guides/deploy/cloudflare.md Outdated Show resolved Hide resolved
@Ekwuno
Copy link
Contributor Author

Ekwuno commented Aug 10, 2022

Thank you for improving our Cloudflare documentation @Ekwuno! Who better to provide it than the source? 😄

I've added some suggestions re: code formatting because we have some specific syntax we use to author our code samples. If you try those and double check, I think that will give you what you're after that fits with our current Docs style. (I actually have an open PR right now documenting this code authoring for our WRITING.md document, so if something is a little off, you could check there!) So see how it looks on your end, make sure it's giving you the code samples you expect, and let me know if you have any questions about this!

Thanks for such a detailed explanation. I will check out the WRITING.md document. Going to accept the suggestions and see how they look in the preview.

Co-authored-by: Sarah Rainsberger <[email protected]>
@Ekwuno
Copy link
Contributor Author

Ekwuno commented Aug 11, 2022

@sarah11918 This is perfect!

@sarah11918
Copy link
Member

@Ekwuno Excellent! I'm glad it's what you wanted!

Thanks again for this contribution to the Docs, and welcome as a first-time contributor! 🥳

@sarah11918 sarah11918 merged commit e45fb3c into withastro:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants