-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content collections tutorial #10035
content collections tutorial #10035
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'd say an unit 7 could be better:
Suggestion:
It's just an idea... maybe it can be improved. And it depends on the intention: to discourage the use of |
So one immediate problem with a Unit 7 (and holy cow, no unit 8!!) is how our tracker was designed to fit 6 units 😅 Also, as you yourself said, the tutorial is LONG. And all you can see when you start is the unit numbers, not for example, that the last one is optional... This is why I am leaning towards being in Chapter 6 (even if the unit title is a little weird for that) and specifically showing it AFTER congratulations in that way. |
Well, we want to give them the option of learning it, but think of how many Astro sites are 1 page portfolios that don't need a collection! (And a lot of new concepts specific to that feature.) That's in part why the tutorial emphasizes the file-based routing and had an additional add-on for those who do have sets of data to manage. So, I would say it's not necessarily a given that the tutorial should push towards collections, but should make it available. |
Hmm yes seen like that... maybe in unit 6 but before "Congratulations" with a link that allows you to skip this step and that targets "Congratulations"? I don't know, it just seems weird to me to add content after "Congratulations". But there are movies that add content after the credits so... 😅 |
Secret bonus track!! 😄 |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
OK, thanks to @ArmandPhilippot for evaluating the code samples and making the neccessary updates! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description (required)
This removes the individual "Extend the tutorial with Content Collections" tutorial and instead add a "bonus/optional" section to the existing blog tutorial
Closes #10025
In particular:
create astro
updates introduced in create-astro updates astro#12083 (minimal option must be chosen via template flag, is no longer a menu item; Typescript template is automatically set tostrict
)Still to do:
strict
TypeScript settingtutorials
folder and theadd-content-collections.mdx
files in other languages. (Is it helpful to keep them for translators because much of the content will be the same as the new file added here?)For Translators
/tutorials/add-content-collections.mdx
file has been deleted but you may wish to go back and find this file from v4 as the basis for your new6-islands/4.mdx
file. It is not identical but it is very similar. You will have to check closely for small changes. You can use the diff in this PR foren/tutorials/add-content-collections.mdx -> en/tutorial/6-islands/4.mdx
Follow up after this PR:
content-layer
branch