Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): recreate basics/layout.mdx #10034

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Nov 15, 2024

Description (required)

  • delete the whole content because it was too out of date
  • translate the english content from scratch

Related issues & labels (optional)

in theory this should update the translation of these PRs, but I think there are many more changes not tracked by Lunaria...

(https://github.com/withastro/docs/commits/main/src/content/docs/en/basics/layouts.mdx?since=2024-07-10T18:34:38.000Z)

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e3f941
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67448fa8d8bba100088293e7
😎 Deploy Preview https://deploy-preview-10034--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trueberryless trueberryless marked this pull request as ready for review November 15, 2024 21:24
@trueberryless trueberryless changed the title i18n(de): update basics/layout.mdx i18n(de): recreate basics/layout.mdx Nov 16, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 20, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/basics/layouts.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

I guess the CI check failing is okay, as mention here, @jsparkdev ?

@sarah11918
Copy link
Member

Just mentioning that this cannot merge with a failing check, because then all of docs will show a failing check because of this on the main branch itself, and it will affect everything!

I would say to remove the link entirely. The content doesn't exist on that page so it's not even a helpful link at all.

These docs are going to be retired soon, and almost all the new docs will be outdated anyway, so you'll probably HAVE to revisit this page. And, presumably at some point someone will update the routing page to actually include this heading, and at that point, the link can be readded.

Once v5 is published, this would be great to tackle: first update the routing page and then come back and add this link!

@jsparkdev
Copy link
Contributor

@trueberryless @sarah11918 Thanks for the nice comment, I guess my suggestion wasn't a good one 😂

@trueberryless
Copy link
Contributor Author

I guess my suggestion wasn't a good one 😂

Dude, no problem at all. I don't want to start talking 'bout all my suggestions which were rejected 😂. HiDeoo alone had probably more work explaining why my suggestions are not gonna merge than just implementing himself 😂 (my bad btw...)

Reminder for me to find this PR again:

TODO @trueberryless - correct link and MANY other things probably

Copy link
Contributor

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsparkdev jsparkdev merged commit a513184 into withastro:main Nov 25, 2024
10 checks passed
@trueberryless trueberryless deleted the bas-lay branch November 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants