-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(de): recreate basics/layout.mdx
#10034
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
basics/layout.mdx
basics/layout.mdx
Co-authored-by: Junseong Park <[email protected]>
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
I guess the CI check failing is okay, as mention here, @jsparkdev ? |
Just mentioning that this cannot merge with a failing check, because then all of docs will show a failing check because of this on the main branch itself, and it will affect everything! I would say to remove the link entirely. The content doesn't exist on that page so it's not even a helpful link at all. These docs are going to be retired soon, and almost all the new docs will be outdated anyway, so you'll probably HAVE to revisit this page. And, presumably at some point someone will update the routing page to actually include this heading, and at that point, the link can be readded. Once v5 is published, this would be great to tackle: first update the routing page and then come back and add this link! |
@trueberryless @sarah11918 Thanks for the nice comment, I guess my suggestion wasn't a good one 😂 |
Dude, no problem at all. I don't want to start talking 'bout all my suggestions which were rejected 😂. HiDeoo alone had probably more work explaining why my suggestions are not gonna merge than just implementing himself 😂 (my bad btw...) Reminder for me to find this PR again: TODO @trueberryless - correct link and MANY other things probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description (required)
Related issues & labels (optional)
in theory this should update the translation of these PRs, but I think there are many more changes not tracked by Lunaria...
(https://github.com/withastro/docs/commits/main/src/content/docs/en/basics/layouts.mdx?since=2024-07-10T18:34:38.000Z)