Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfig alias with import.meta.glob #9560

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Fix tsconfig alias with import.meta.glob #9560

merged 4 commits into from
Jan 8, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 1, 2024

Changes

fix #9258

#9258 (comment) explains why the fix is made

Testing

added a new test

Docs

n/a. bug fix

Copy link

changeset-bot bot commented Jan 1, 2024

🦋 Changeset detected

Latest commit: 9935886

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Jan 1, 2024
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible! This has been a very longstanding issue. Glad you were able to figure out a fix! 🙌

packages/astro/src/vite-plugin-config-alias/index.ts Outdated Show resolved Hide resolved
@rglanz
Copy link

rglanz commented Jan 6, 2024

@bluwy ship this pr into my veins, please 😭

(found this today as I was trying to hack aliases + glob in my astro project)

@bluwy bluwy merged commit 8b9c484 into main Jan 8, 2024
4 checks passed
@bluwy bluwy deleted the alias-glob branch January 8, 2024 03:06
@astrobot-houston astrobot-houston mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta.glob with path aliases won't work
4 participants