Move create-astro async tasks to end #9470
Conversation
🦋 Changeset detectedLatest commit: 5371bfc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: create-astro
|
Genius |
|
This is great! We discussed this on Discord and I'm excited to get this reviewed as soon as we can. I'd consider this a minor change, which means we likely won't merge and release until the start of the new year. Other than that, I'm sure folks will review as soon as they can! |
There was a problem hiding this comment.
This is great, love the idea! Thanks for contributing.
Some tiny nits about how the labels are displayed, but I'm happy with this change overall. We'll definitely want to try this with the --yes and --no flags to make sure the UI still makes sense before a final approval.
Co-authored-by: Nate Moore <[email protected]>
Thanks! I think the UI looks great with
|
There was a problem hiding this comment.
What a delightful contribution, @onsclom! I've just left an idea for the changeset from docs because I think the changelog message could show off this feature a little better: let's make it as delightful as the feature itself! 🥳
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Defer async actions until after user input to improve user experience. More details were discussed in this Astro Discord thread.
create-astro.mp4