Fix transitions with non-recommended headers #9464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The syntax of the Content-Type header specified by the HTTP Semantics RFC is as follows:
The
;
that marks the start of the parameters may, even though not recommended, be preceded by any number of white spaces. The previous implementation of thefetchHTML
function would not accept a header in that form and do full page reload.This PR takes that into account and replaces the media type extraction from the header with an implementation that works for any spec-compliant server, even without using recommended practices.
Testing
A new integration test was added for a page replying with the following header:
Docs
I don't think this needs any docs change