Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Preact Forwarded Ref components not working in astro files when React integration is enabled #9403

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fix Preact Forwarded Ref components not working in astro files when React integration is enabled #9403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0b8eea
Fix Preact Forwarded Ref components not working in astro files when R…
knpwrs Dec 11, 2023
2d5818d
Handle undefined $$typeof
knpwrs Dec 11, 2023
b9f9c8c
Add changeset
knpwrs Dec 11, 2023
f636113
Use Symbol.for
knpwrs Dec 11, 2023
a7f2dd1
:zap:
knpwrs Dec 11, 2023
9453b7e
Merge branch 'main' into patch-1
natemoo-re Dec 11, 2023
a800f7c
Update .changeset/breezy-hairs-yell.md
natemoo-re Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-hairs-yell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/react': patch
---

Prevents unsupported `forwardRef` components created by Preact from being rendered by React
3 changes: 3 additions & 0 deletions packages/integrations/react/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ async function check(Component, props, children) {
}
if (typeof Component !== 'function') return false;

// Preact forwarded-ref components can be functions, which React does not support
if (typeof Component === 'function' && Component['$$typeof'] === Symbol.for('react.forward_ref')) return false;

if (Component.prototype != null && typeof Component.prototype.render === 'function') {
return React.Component.isPrototypeOf(Component) || React.PureComponent.isPrototypeOf(Component);
}
Expand Down
Loading