Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): correctly pull the ssr entry during build #9380

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ematipico
Copy link
Member

Changes

Closes #9354

Testing

Added a new test, and tested locally.

Docs

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: d18467c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 8, 2023
@ematipico ematipico force-pushed the fix/hybrid-build-i18n branch from a2db5d8 to d18467c Compare December 8, 2023 16:38
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Dec 8, 2023
Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! Thank you for those helpful comments!

@ematipico ematipico merged commit ea09182 into main Dec 11, 2023
13 checks passed
@ematipico ematipico deleted the fix/hybrid-build-i18n branch December 11, 2023 10:11
@astrobot-houston astrobot-houston mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro fails to build with prefixDefaultLocale: true,
2 participants