Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unflag dev overlay #9232

Merged
merged 7 commits into from
Nov 29, 2023
Merged

feat: unflag dev overlay #9232

merged 7 commits into from
Nov 29, 2023

Conversation

Princesseuh
Copy link
Member

Changes

Unflag the dev overlay and add options to disable it and choose if it's

Testing

We'll see if our tests pass with it enabled, hopefully it's not a "unflagging Assets after multiple months of it being flagged broke everything"

Docs

I assume the sudden apparition of the dev overlay will be mentioned in the blog and in the migration guide?

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 1f328b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 29, 2023
@bluwy bluwy mentioned this pull request Nov 29, 2023
3 tasks
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also need a changeset

@matthewp matthewp merged commit 34e96b1 into next Nov 29, 2023
14 checks passed
@matthewp matthewp deleted the feat/unflag-overlay branch November 29, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants