-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay look-and-feel polish #9230
Conversation
🦋 Changeset detectedLatest commit: 9d6640b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm bothered by the number of tabs you have open in your browser, but aside from that this lgtm. |
efdf348
to
e0aa82f
Compare
Would love to help on the design side of things when it makes sense! I wasn't part of the bug bash or follow-up but seems like quite a few things changed. Quick item I would adjust is the name "Menu" I would alter to "Home". Technically they are all menus so I found that to be odd. |
Rebased! I walked through this PR this morning with @Princesseuh as well and got her verbal +1/LGTM with a couple of change requests. Merging now so that this PR isn't blocking future incremental improvements. For @Princesseuh -- I did go ahead and remove two things that we discussed this morning from this PR, to re-tackle in the future:
|
Changes
Resolves a collection of feedback items from the bug bash:
The two major items tackled in this PR are:
Toolbar UI/UX Polish -- Removed the previous explicit dismiss/collapse behavior and UI. The toolbar is now hidden by default, appears when you hover on/near it, and disappears soon afterwards if you move your mouse away. Escape key & clicking outside the toolbar are now possible. Shrank the toolbar to be less obtrusive.
Improved Active Plugin Management -- There is now a single plugin active at any one time. Switching plugins now always closes a previously open plugin. This loses the "settings + another plugin open at the same time" nice-to-have story, but the simplicity gain is well worth it IMO.
Demo
Note: Screen Hero doesn't display keyboard input. There's a moment where the plugin closes and then the toolbar hides. This is because I pressed the escape key twice.
Astro.Dev.Overlay.Demo.mp4
Reviewing
This PR includes #9220. I'll rebase to remove from this PR as soon as that merges into
next
.There was no obvious way to separate this PR, since the UI changes also impacted the behavior changes. I did my best and turned this into two different commits with two different focuses (first style, then behavior) but I would still recommend reviewing all in one go.
@Princesseuh I'd actually like to give you in person walkthrough as well, if you're available tomorrow. Similar to the logging work, I took a lot of discretion with look/feel here and want to merge that back together with the behaviors that you care about, if possible.
Testing
Docs