Fix esbuild warning for local dev

[bluwy]

Changes

Recently we upgraded esbuild, which (for some reason) does partial linting and flagged this code in packages/astro:

▲ [WARNING] The "??" operator here will always return the left operand [suspicious-nullish-coalescing]

    src/vite-plugin-scanner/scan.ts:75:43:
      75 │             settings?.config.output === 'hybrid' ?? false
         ╵                                                  ~~

  The left operand of the "??" operator here will never be null or undefined, so it will always be
  returned. This usually indicates a bug in your code:

    src/vite-plugin-scanner/scan.ts:75:6:
      75 │             settings?.config.output === 'hybrid' ?? false
         ╵             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[05:51 PM] ⚠ updated with warnings:
[object Object]
[05:51 PM] ✔ updated

I removed the ?? false in this PR.

Testing

Existing test should pass

Docs

n/a. internal refactor.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f4618e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[bluwy]

Merging this in since it's a simple change 😬