Improve markdown rendering performance #8532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93f7b53 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
feat: markdown
bluwy
commented
Sep 13, 2023
Comment on lines
-94
to
-95
| const astroData = safelyGetAstroData(renderResult.vfile.data); | ||
| if (astroData instanceof InvalidAstroDataError) { |
There was a problem hiding this comment.
astroData here is used for astroData.frontmatter only. I moved frontmatter to return directly from processor.render() above instead.
Comment on lines
+139
to
+142
| const astroData = safelyGetAstroData(result.data); | ||
| if (astroData instanceof InvalidAstroDataError) { | ||
| throw astroData; | ||
| } |
There was a problem hiding this comment.
Rendering markdown now handles and throws InvalidAstroDataError directly. Otherwise the consumer who have needed to do it manually.
matthewp
approved these changes
Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improve markdown rendering performance by sharing the markdown/unified processor.
Will be doing the same for MDX next.
I tried benchmarking this, but unfortunately they don't show a big difference. Technically it should improve things though. When I finish the MDX change I could probably test it on our docs build and see if there's a clearer difference there.
Testing
Ran astro/remark/mdx tests locally.
Docs
n/a