Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow node builtins in runtime #8523

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Updates our eslint settings to detect Node built-ins that accidentally make their way into our runtime code.
  • Closes PLT-572
  • Might catch a few issues in the future, but doesn't cover everything.

Testing

Verified locally

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

⚠️ No Changeset found

Latest commit: 5c77af8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@natemoo-re
Copy link
Member Author

Got the #NWTWWHB for this on Discord, so I'm going to merge!

@natemoo-re natemoo-re merged commit aac51bd into main Sep 12, 2023
@natemoo-re natemoo-re deleted the chore/eslint-disallow-node-builtins branch September 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant