Vt follow redirects #8522
Merged
Vt follow redirects #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e6c9040 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Sep 12, 2023
| // If there is a problem fetching the new page, just do an MPA navigation to it. | ||
| if (!ok) { | ||
| if (!ok || contentType !== 'text/html') { |
There was a problem hiding this comment.
so nice we have this in this PR too!
There was a problem hiding this comment.
Not as clever as thought, see fix in PR #8537
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With redirects, the location had to be updated to reflect the final destination in the browsers address bar.
Redirect errors, like same origin violation, are handled as any other errors of
fetchby full load of the requestedhref(as same origin policy would prevent us from accessing the target DOM)
While we are looking at the response object now, I have also grabbed the content-type for the parser.
Testing
two new e2e tests
Docs
n/a bug fix