Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore horizontal scroll position on history navigation (view transitions) #8505

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

martrapp
Copy link
Member

Changes

While we recorded scrollY for history navigation, we ignored scrollX up to now.
Added scrollX to history state

Testing

added e2e test

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: c48860f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 11, 2023
@martrapp martrapp marked this pull request as draft September 11, 2023 13:49
@martrapp martrapp marked this pull request as ready for review September 11, 2023 13:50
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's wait for the final 👍 from @matthewp

@matthewp matthewp merged commit 2db9762 into withastro:main Sep 12, 2023
@astrobot-houston astrobot-houston mentioned this pull request Sep 12, 2023
@martrapp martrapp deleted the scrollX branch September 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants