feat(assets): Allow users to set a custom endpoint to use for image optimization #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eeabe3e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
approved these changes
Sep 11, 2023
delucis
reviewed
Sep 13, 2023
| * { | ||
| * image: { | ||
| * // Example: Use a custom image endpoint | ||
| * endpoint: './src/image-endpoint.ts', |
There was a problem hiding this comment.
Do we have docs we could link to for what the contents of image-endpoint.ts should look like?
There was a problem hiding this comment.
We don't, but there's kinda no defined shape for it, it's a normal endpoint, you can technically answer anything you want from it.
sarah11918
reviewed
Sep 13, 2023
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What the title says!
Q: Why do we need this?
A: It unlocks the ability for adapters to set a endpoint that's more suited to their platform. For instance, maybe the Deno adapter would set an endpoint that uses
Deno.readFileinstead of using afetch. We don't have those endpoints yet, but we could with this!In addition, this is a nice things for users who want more control over the endpoint, especially in SSR you might want to use an empty endpoint or something to avoid having the image service bundled in completely.
This is ultimately a stepping stone to fix those three issues:
<Image>component when transforming local images #5699Testing
Added a test
Docs
Added docs!