Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in the client-side router #8166

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Fixes in the client-side router #8166

merged 3 commits into from
Aug 22, 2023

Conversation

martrapp
Copy link
Member

Changes

There had been some corner cases for pages that did not include <ViewTransitions> in there <head>

Testing

added two e2e tests

Docs

n/a bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023

🦋 Changeset detected

Latest commit: 2fb0bb1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 20, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally reasonable, thanks for the fix!

@matthewp matthewp merged commit fddd4dc into withastro:main Aug 22, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Aug 22, 2023
@martrapp martrapp deleted the mt_history_fix branch August 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants