Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types to specify that compress defaults to true #8072

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Update types to specify that compress defaults to true #8072

merged 2 commits into from
Aug 14, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • The option was already changed to default to true, but the types were not changed. This updates them, as well as the docs.

Testing

N/A

Docs

  • In the types file

@matthewp matthewp requested a review from a team as a code owner August 14, 2023 14:05
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 48d6c0c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 14, 2023
ElianCodes
ElianCodes approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to me!

sarah11918
sarah11918 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matthew! Just committed a change directly because I couldn't suggest over multiple lines. Happy with this! Thanks so much for jumping in! 🙌

@matthewp matthewp merged commit 4477bb4 into next Aug 14, 2023
14 checks passed
@matthewp matthewp deleted the next-cli-config branch August 14, 2023 15:10
@astrobot-houston astrobot-houston mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElianCodes ElianCodes ElianCodes approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@Princesseuh Princesseuh Princesseuh approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewp @Princesseuh @sarah11918 @natemoo-re @ElianCodes