Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix github search link in README.md #8063

Merged
merged 2 commits into from
Aug 14, 2023
Merged

docs: fix github search link in README.md #8063

merged 2 commits into from
Aug 14, 2023

Conversation

martrapp
Copy link
Member

Changes

There is a broken link at the bottom of the README.md.

Browse projects with Astro Sitemap on GitHub for more examples!

The fix corrects the query parameters of the link.

before after
image image

Testing

Tested manually with the fixed link

Docs

/cc @withastro/maintainers-docs for feedback!
The README.md for @astrojs/sitemap is part of the integrations-guide and has translations for es and zh-cn
The fixed URL can be copied as is for the other languages, no need for real translation.

@martrapp martrapp requested a review from a team as a code owner August 14, 2023 09:20
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 5ed6832

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 14, 2023
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martrapp!

Thanks for your PR! Looks good to me!

@ElianCodes ElianCodes merged commit bee284c into withastro:main Aug 14, 2023
@astrobot-houston astrobot-houston mentioned this pull request Aug 14, 2023
@martrapp martrapp deleted the sitemap-docs-fix-query branch August 14, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants