feat: pass logger to integrations #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab3b54e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
force-pushed
the
feat/astro-logger-integrations-plt-690
branch
from
1eb8b13
to
9c368e4
Compare
ematipico
force-pushed
the
feat/astro-logger-integrations-plt-690
branch
from
9c368e4
to
6a4cd35
Compare
delucis
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Changelog and public API look good to me! Thanks @ematipico 💜
|
The diff is showing all changes unrelated to a logger. Like the capitalization change to API routes. Is that a mistake? |
ematipico
force-pushed
the
feat/astro-logger-integrations-plt-690
branch
from
6a4cd35
to
ab3b54e
Compare
|
@matthewp now it should be fine |
bluwy
approved these changes
Jul 27, 2023
ematipico
added a commit
that referenced
this pull request
Jul 31, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 3, 2023
ematipico
added a commit
that referenced
this pull request
Aug 4, 2023
ematipico
added a commit
that referenced
this pull request
Aug 4, 2023
ematipico
added a commit
that referenced
this pull request
Aug 4, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
|
Thank you @ematipico ! I just updated my integration to use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I created two classes:
Logger, basic class. The objective of this class is to be used internally in our codebase. Ideally, we will pass around an instance of this class instead of passinglogging. I plan to make this change gradually in the future.AstroIntegrationLogger, similar toLogger, this class has thelabelstored inside of it. The main idea is that integrations should not know anything about labels.If an integration needs to do some logging with a different label - which I assume it's rare - they can use the
forkfunction, which returns a new logger which has the same logging options.Testing
Current tests should pass.
Docs
/cc @withastro/maintainers-docs for feedback!