Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sitemap excludes nested error pages #7722

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Test updated to include nested 404 page

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: 49ddbb6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re marked this pull request as ready for review July 19, 2023 21:31
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 19, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense to me, but I wasn’t able to test locally with Starlight’s docs where I first noticed the regression.

Thanks for the quick fix Nate! 💜

@natemoo-re natemoo-re merged commit 77ffcc8 into main Jul 19, 2023
@natemoo-re natemoo-re deleted the fix/sitemap-404--plt-704 branch July 19, 2023 22:05
@astrobot-houston astrobot-houston mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants