Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esbuild target for Deno #7687

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Update esbuild target for Deno #7687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6848445
update esbuild target for Deno
kwhinnery Jul 17, 2023
1423953
add changeset file
kwhinnery Jul 17, 2023
e0d0033
Merge branch 'main' into deno-esbuild-target
kwhinnery Jul 18, 2023
3c93e82
add test that exercises esnext feature (top-level await)
kwhinnery Jul 18, 2023
ab7df5f
Merge branch 'main' into deno-esbuild-target
Princesseuh Jul 18, 2023
fed2e3e
Merge branch 'main' into deno-esbuild-target
kwhinnery Jul 18, 2023
e06601a
Merge branch 'main' into deno-esbuild-target
kwhinnery Jul 18, 2023
7360ae0
Merge branch 'main' into deno-esbuild-target
kwhinnery Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-chicken-pay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/deno': minor
---

Update build target for Deno to esnext to allow supported language features on the runtime.
2 changes: 1 addition & 1 deletion packages/integrations/deno/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
const pth = fileURLToPath(entryUrl);

await esbuild.build({
target: 'es2020',
target: 'esnext',
platform: 'browser',
entryPoints: [pth],
outfile: pth,
Expand Down
9 changes: 9 additions & 0 deletions packages/integrations/deno/test/basics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ Deno.test({
assertEquals(p!.innerText, varContent);
});

await t.step('Can use a module with top-level await', async () => {
const resp = await fetch(app.url);
const html = await resp.text();

const doc = new DOMParser().parseFromString(html, `text/html`);
const p = doc!.querySelector('p#module-value');
assertEquals(p!.innerText, 'bar');
});

await t.step('Works with Markdown', async () => {
const resp = await fetch(new URL('markdown', app.url));
const html = await resp.text();
Expand Down
2 changes: 2 additions & 0 deletions packages/integrations/deno/test/fixtures/basics/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
import { someData } from '../util/data';
import ReactComponent from '../components/React.jsx';
const envValue = import.meta.env.SOME_VARIABLE;
---
Expand All @@ -10,6 +11,7 @@ const envValue = import.meta.env.SOME_VARIABLE;
<body>
<h1>Basic App on Deno</h1>
<p id="env-value">{envValue}</p>
<p id="module-value">{someData.foo}</p>
<ReactComponent />
</body>
</html>
14 changes: 14 additions & 0 deletions packages/integrations/deno/test/fixtures/basics/src/util/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
export interface Data {
foo: string;
}

export async function getData(): Promise<Data> {
return new Promise((resolve, _reject) => {
setTimeout(() => {
resolve({ foo: "bar" });
}, 100);
});
}

// Testing top-level await, a feature supported in esnext
export const someData = await getData();