Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental flag for redirects config #7686

Merged
merged 11 commits into from
Jul 19, 2023
Merged

Remove experimental flag for redirects config #7686

merged 11 commits into from
Jul 19, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes the need for the experimental: { redirects: true } config.

Testing

  • Tests updated to reflect the change

Docs

  • TBD

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e0edf82

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 17, 2023
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 17, 2023
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Jul 17, 2023
github-actions[bot]
github-actions bot previously requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp marked this pull request as ready for review July 17, 2023 19:06
@matthewp matthewp requested a review from a team as a code owner July 17, 2023 19:06
natemoo-re
natemoo-re approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

sarah11918
sarah11918 reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when a feature graduates from experimental!

Just some tiny things to extra-double-triple check here, then redirects is 2.9 bound! 🚂

.changeset/dry-beers-grow.md Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/integrations/netlify/README.md Outdated Show resolved Hide resolved
@matthewp matthewp mentioned this pull request Jul 17, 2023
Merged
@matthewp matthewp merged commit ec745d6 into main Jul 19, 2023
@matthewp matthewp deleted the redirects-no-exp branch July 19, 2023 13:31
@astrobot-houston astrobot-houston mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@natemoo-re natemoo-re natemoo-re approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @sarah11918 @natemoo-re