Fix multiple create-astro registry issues
#7539
Merged
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e95455 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
ematipico
approved these changes
Jun 30, 2023
natemoo-re
reviewed
Jun 30, 2023
github-actions
bot
added
the
pkg: astro
natemoo-re
force-pushed
the
jc-fix-create
branch
from
e353fd1 to
d30c06d
Compare
natemoo-re
changed the title
create-astro registry issues
natemoo-re
approved these changes
Jun 30, 2023
Merged
matthewp
pushed a commit
that referenced
this pull request
Jul 11, 2023
* fix: getVersion Error when registry ends with '/' * Update .changeset/old-seahorses-fold.md * Update .changeset/old-seahorses-fold.md * refactor: cleanup registry logic * chore: update changeset * fix(create-astro): update registry logic to rely on `fetch` * chore: update changeset * chore: update lockfile * Update old-seahorses-fold.md --------- Co-authored-by: jincheng32537 <[email protected]> Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/)When I use the registry "https://registry.npmmirror.com/", create-astro will be failed because the request of "getVersion" gets the 404 error and the error is not be caught.
Testing
I add the code and link the local package to global by using
pnpm link -g, and then I runcreate-astroagain. I am successfully into creating app.Docs
Bug fixes only